Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to seek to a percentage of the total duration. #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jakem72360
Copy link

I had to rewrite a large portion of the script to get this to work nicely, but everything is functional, including two separate lines of history for each seek mode. I've also made the cursor start at a fixed position, rather than depending on the duration of the video since the latter approach makes muscle-memory inputs impossible. Please let me know your thoughts on this

@occivink
Copy link
Owner

occivink commented Jan 7, 2020

Thanks, this would be a good addition indeed.
I'm not a big fan of the changes to the timestamp seeker, I find the 'shift the numbers to the left' less intuitive, and the ability to specify milliseconds (which I use when I want to compare exact frames) was lost. I also do use the feature where it starts at the 'most significant' digit, but maybe we can make that one optional so that you can also rely on muscle memory.

Also it would be nice to clamp the %-seeker to 100%.

@jakem72360
Copy link
Author

jakem72360 commented Jan 10, 2020

There's a couple things I'd like to clarify;

I use when I want to compare exact frames

I find three digits of milliseconds to be way too verbose. Perhaps this functionality could be re-implemented elsewhere, say for example, a "seek to frame number"? That's partly why I added the mode variable and separate history lines, for this kind of thing. Could you clarify what you do when you "compare exact frames"?

clamp the seeker to 100%

What do you mean exactly? MPV caps the seek duration for us so specifying a percentage above 100% still skips to the end of the video.

@occivink
Copy link
Owner

By comparing exact frames, I mean that sometimes I open two mpv instances (with different video settings, for example) on the same file, seek to a random position in one, and then seek to the same frame by using millisecond precision.

mpv doesn't expose (or even knows?) frame numbers so that is not an option.

I understand that most of the time you don't need such precision, but the advantage of the current input style is that you can leave them at 0 if you don't care, it doesn't get in the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants